Skip to content

Update tests to use best practices#935

Merged
kevmoo merged 1 commit intomainfrom
test_best_practices
Feb 9, 2026
Merged

Update tests to use best practices#935
kevmoo merged 1 commit intomainfrom
test_best_practices

Conversation

@kevmoo
Copy link
Copy Markdown
Member

@kevmoo kevmoo commented Feb 5, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

Package publishing

Package Version Status Publish tag (post-merge)
package:args 2.8.0 ready to publish args-v2.8.0
package:async 2.13.1-wip WIP (no publish necessary)
package:characters 1.4.1 already published at pub.dev
package:collection 1.20.0-wip WIP (no publish necessary)
package:convert 3.1.3-wip WIP (no publish necessary)
package:crypto 3.0.7 already published at pub.dev
package:fixnum 1.2.0-wip WIP (no publish necessary)
package:lints 6.1.0 already published at pub.dev
package:logging 1.3.1-wip WIP (no publish necessary)
package:os_detect 2.0.4-wip WIP (no publish necessary)
package:path 1.9.2-wip WIP (no publish necessary)
package:platform 3.1.7-wip WIP (no publish necessary)
package:typed_data 1.4.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

PR Health

License Headers ✔️ 
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/collection/benchmark/legacy_quicksort.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
characters None 1.4.1 1.4.1 1.4.1 ✔️
collection Breaking 1.19.1 1.20.0-wip 1.20.0-wip ✔️
crypto None 3.0.7 3.0.7 3.0.7 ✔️
logging None 1.3.0 1.3.1-wip 1.3.1-wip ✔️
typed_data None 1.4.0 1.4.1-wip 1.4.1-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Unused Dependencies ⚠️
Package Status
characters ✔️ All dependencies utilized correctly.
collection ✔️ All dependencies utilized correctly.
crypto
❗ Show Issues
These packages may be unused, or you may be using assets from these packages:
  * typed_data
logging ✔️ All dependencies utilized correctly.
typed_data ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

kevmoo added a commit to kevmoo/dash_skills that referenced this pull request Feb 5, 2026
@kevmoo
Auto-updates
eb666c9 
I asked gemini "are there any updates you'd like to make to SKILL.md that would have made your job easier?"

per it's work on dart-lang/core#935

This is the delta it created
@kevmoo kevmoo changed the title skills playing Update tests to use best practices Feb 9, 2026
@kevmoo kevmoo marked this pull request as ready for review February 9, 2026 16:06
@kevmoo kevmoo requested review from a team and lrhn as code owners February 9, 2026 16:06
@natebosch
Copy link
Copy Markdown
Member

natebosch commented Feb 9, 2026

Can you update the first comment with the planned content for the commit message? We should describe the code changes and how they were produced.

@kevmoo kevmoo merged commit d981f90 into main Feb 9, 2026
31 checks passed
@kevmoo kevmoo deleted the test_best_practices branch February 9, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natebosch natebosch natebosch approved these changes

@lrhn lrhn Awaiting requested review from lrhn lrhn is a code owner

Assignees

No one assigned

Labels

package:characters package:collection package:crypto package:logging package:typed_data

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @natebosch
⚡